Skip to content

fix: don't warn on routine client-disconnect write/flush errors #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 4 commits into from
Aug 4, 2026
+12 −4
Merged

fix: don't warn on routine client-disconnect write/flush errors #2589

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1519fde
fix: don't mislabel flush errors as "not a flusher"
dunglas Aug 4, 2026
43e6919
fix: log expected flush errors at debug, not warn
dunglas Aug 4, 2026
f83f784
fix: match existing warn level and flatten go_sapi_flush
dunglas Aug 4, 2026
9b6e356
fix: log routine write/flush failures at debug, not warn
dunglas Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions frankenphp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,8 +451,8 @@ func go_ub_write(threadIndex C.uintptr_t, cBuf *C.char, length C.size_t) (C.size
if e != nil {
ctx = thread.context()

if fc.logger.Enabled(ctx, slog.LevelWarn) {
fc.logger.LogAttrs(ctx, slog.LevelWarn, "write error", slog.Any("error", e))
if fc.logger.Enabled(ctx, slog.LevelDebug) {
fc.logger.LogAttrs(ctx, slog.LevelDebug, "write error", slog.Any("error", e))
}
}

Expand Down Expand Up @@ -624,12 +624,20 @@ func go_sapi_flush(threadIndex C.uintptr_t) bool {
if fc.responseController == nil {
fc.responseController = http.NewResponseController(fc.responseWriter)
}
if err := fc.responseController.Flush(); err != nil {
ctx := thread.context()

err := fc.responseController.Flush()
if err == nil {
return false
}

ctx := thread.context()

if errors.Is(err, http.ErrNotSupported) {
if globalLogger.Enabled(ctx, slog.LevelWarn) {
globalLogger.LogAttrs(ctx, slog.LevelWarn, "the current responseWriter is not a flusher, if you are not using a custom build, please report this issue", slog.Any("error", err))
}
} else if globalLogger.Enabled(ctx, slog.LevelDebug) {
globalLogger.LogAttrs(ctx, slog.LevelDebug, "flush error", slog.Any("error", err))
}

return false
Expand Down
Loading