Skip to content

fix: reset session state when session ext is not linked at build time #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 1 commit into from
Jul 18, 2026
+15 −1
Merged

fix: reset session state when session ext is not linked at build time #2523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion frankenphp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,21 @@ ZEND_TSRMLS_CACHE_DEFINE()
*
* @see https://github.com/DataDog/dd-trace-php/pull/3169 for an example
*/
static const char *MODULES_TO_RELOAD[] = {"filter", NULL};
static const char *MODULES_TO_RELOAD[] = {
"filter",
#ifndef HAVE_PHP_SESSION
/* When the session extension is not visible at build time (e.g. it is
* loaded as a shared module), frankenphp_reset_session_state() is
* compiled out. Reset the session module through the registry instead so
* PS(id) is cleared between worker requests and a stale id cannot bleed
* across concurrent clients. See GHSA-v3ph-cgqh-r8p5.
*
* Unlike frankenphp_reset_session_state(), the module RSHUTDOWN frees
* save handlers registered from the worker bootstrap; that is an
* acceptable trade-off for a build where the extension isn't linked. */
"session",
#endif
NULL};

frankenphp_version frankenphp_get_version() {
return (frankenphp_version){
Expand Down
Loading