refactor: removes some duplications in tests - #1783
Merged
Merged
Conversation
AlliBalliBaba
marked this pull request as ready for review
August 3, 2025 13:55
withinboredom
approved these changes
Aug 3, 2025
withinboredom
left a comment
withinboredom
left a comment
Member
There was a problem hiding this comment.
This will make life a bit easier... :D
dunglas
reviewed
Aug 3, 2025
dunglas
requested changes
Aug 7, 2025
Co-authored-by: K茅vin Dunglas <kevin@dunglas.fr>
dunglas
approved these changes
Aug 8, 2025
henderkes
pushed a commit
to static-php/frankenphp
that referenced
this pull request
Sep 11, 2025
* Removes test duplications. * Adds t.Helper(). * Fixes tests. * UUpdate frankenphp_test.go Co-authored-by: K茅vin Dunglas <kevin@dunglas.fr> --------- Co-authored-by: K茅vin Dunglas <kevin@dunglas.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.