Skip to content

Clarify closing identifier indentation behaviour of Heredoc #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlwaysVictorious wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −8
Open

Clarify closing identifier indentation behaviour of Heredoc #5763

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c015d4
Example PHP 7.3.0: clarify indentation concerns the identifier not th…
AlwaysVictorious Aug 14, 2026
ee1dabd
Clarify Heredoc closing identifier indentation behaviour
AlwaysVictorious Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions language/types/string.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,9 @@ echo 'Variables do not $expand $either', PHP_EOL;
</simpara>

<simpara>
The closing identifier may be indented by space or tab, in which case
the indentation will be stripped from all lines in the doc string.
The closing identifier may be indented with spaces or tabs. Whitespace
equal to the closing identifier's indentation is then removed from the
beginning of every line in the Heredoc string.

@kamil-tekiela kamil-tekiela Aug 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
beginning of every line in the Heredoc string.
beginning of every line in the heredoc string.

Prior to PHP 7.3.0, the closing identifier <emphasis>must</emphasis>
begin in the first column of the line.
</simpara>
Expand All @@ -233,20 +234,20 @@ echo 'Variables do not $expand $either', PHP_EOL;
<programlisting role="php">
<![CDATA[
<?php
// no indentation
// closing identifier not indented
echo <<<END
a
b
c
\n
END;

// 4 spaces of indentation
// closing identifier indented with 3 spaces; 3 spaces stripped from each line
echo <<<END
a
b
c
END;
END;
]]>
</programlisting>
&example.outputs.73;
Expand All @@ -256,9 +257,9 @@ echo <<<END
b
c

a
b
c
a
b
c
]]>
</screen>
</example>
Expand Down