ext/pcre: document variable-length lookbehind and longer subpattern names (PHP 8.4) - #5739
Open
lacatoire wants to merge 1 commit into
Open
ext/pcre: document variable-length lookbehind and longer subpattern names (PHP 8.4)#5739lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
… names (PCRE2 10.44)
lacatoire
force-pushed
the
pcre-8.4-lib-update-changes
branch
from
August 4, 2026 11:48
eba3d4f to
646ba2c
Compare
jordikroon
requested changes
Aug 13, 2026
| </para> | ||
| <simpara> | ||
| As of PHP 8.4.0, which bundles PCRE2 10.44, the maximum length of a | ||
| subpattern name is 128 characters; prior to PHP 8.4.0 it was 32 characters. |
Member
There was a problem hiding this comment.
Suggested change
| subpattern name is 128 characters; prior to PHP 8.4.0 it was 32 characters. | |
| subpattern name is 128 characters; previously it was 32 characters. |
| of the section on once-only subpatterns. | ||
| </para> | ||
| <simpara> | ||
| The fixed-length restriction described above applies prior to PHP 8.4.0. |
Member
There was a problem hiding this comment.
We shouldn't mention that the behavior described above applies to older versions. Instead, we should move the older behaviour below and state that the current description applies to PHP 8.4.0 and later. The documentation should reflect the latest version by default, whereas behaviour from older versions should be documented separately as historical information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the following issues:
PHP 8.4 Documentation Tracker (view)
PHP 8.4 Documentation Tracker (view)