intl: document the procedural style of IntlGregorianCalendar methods - #5619
Open
lacatoire wants to merge 1 commit into
Open
intl: document the procedural style of IntlGregorianCalendar methods#5619lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
lacatoire
force-pushed
the
doc/intlgregcal-procedural
branch
2 times, most recently
from
June 16, 2026 11:58
1b16799 to
4f8ae13
Compare
lacatoire
force-pushed
the
doc/intlgregcal-procedural
branch
from
June 23, 2026 14:07
4f8ae13 to
9be3167
Compare
jordikroon
requested changes
Aug 13, 2026
| </methodsynopsis> | ||
| <simpara> | ||
| Gets the Gregorian Calendar change date. This is the point at which the | ||
| calendar switches from Julian dates to Gregorian dates, expressed as a UNIX |
Member
There was a problem hiding this comment.
Suggested change
| calendar switches from Julian dates to Gregorian dates, expressed as a UNIX | |
| calendar switches from Julian dates to Gregorian dates, expressed as a Unix |
| </methodsynopsis> | ||
| <simpara> | ||
| Sets the Gregorian Calendar change date. This is the point at which the | ||
| calendar switches from Julian dates to Gregorian dates, expressed as a UNIX |
Member
There was a problem hiding this comment.
Suggested change
| calendar switches from Julian dates to Gregorian dates, expressed as a UNIX | |
| calendar switches from Julian dates to Gregorian dates, expressed as a Unix |
|
|
||
| </para> | ||
| <simpara> | ||
| The Gregorian Calendar change date, expressed as a UNIX timestamp in |
Member
There was a problem hiding this comment.
Suggested change
| The Gregorian Calendar change date, expressed as a UNIX timestamp in | |
| The Gregorian Calendar change date, expressed as a Unix timestamp in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The procedural functions
intlgregcal_get_gregorian_change,intlgregcal_is_leap_yearandintlgregcal_set_gregorian_changewere undocumented. This adds their procedural synopsis to the existing OO method pages (mirroring the IntlCalendar convention), fills the short descriptions, and drops the&warn.undocumented.func;placeholders.The deprecated
intlgregcal_create_instanceis intentionally left out.