Add a non-normative hardware-contract TOML example for owner review - #26
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…t example. Co-authored-by: Cursor <cursoragent@cursor.com>
swgiacomelli
marked this pull request as ready for review
August 14, 2026 20:28
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 532e6c207a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
Addressed the review findings in commit
Validation completed: the example parses as TOML, all five example rows satisfy the documented source/state invariants, relative links resolve, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[ ]cannot mean both "not yet reviewed" and "reviewed, sources silent," and an unchecked repository-owned decision looks non-binding even when the README has named it.docs/peripheral-driver-resources/HARDWARE_CONTRACT.toml.example(synthetic EX1234 placeholders) and document thedeclared/provisional/confirmed/omissionvocabulary in the existing source-registry resource pack and documentation guide, the same optional-adoption pattern asSOURCES.toml.example.ph-temt6000-alsAdd portable device behavioral model skill #17 needed a binding named reference AFE while vendor-source rows stayed provisional; markdown checkboxes could not express that split.Test plan
HARDWARE_CONTRACT.toml.exampleparses as TOML and retains synthetic placeholders.Made with Cursor