Peter dev

[phonkee]

No description provided.

[Copilot]

Pull request overview

This PR is a significant parser/AST refactor and documentation expansion for attribs, adding richer source-span error reporting, new tag options (required/disabled/positional), and an “ignore unknown attributes” mode across the public API and debug tooling.

Changes:

• Refactors parser.Parse to return a top-level AST node with SourceSpan-based errors and adds typed value helpers (AsBool/AsInt/...), token helpers, and matcher/item utilities.
• Extends struct tag parsing to support required, disabled, and positional arguments (pos=N), and threads ignoreUnknown through Definition.Parse and Debug.
• Rewrites/expands README and adds extensive new unit tests across parser, lexer, and tag parsing.

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
attr.go	Updates reflection-based setter to consume new AST shape and adds positional argument assignment.
debug.go	Threads ignoreUnknown through debug parsing.
definition.go	Changes public Parse signature to include ignoreUnknown and adapts to new parser return type.
definition_test.go	Updates tests for new Parse signature.
example/example.go	Updates example to pass ignoreUnknown and adds an extra tag attribute.
go.mod	Updates Go version directive and test dependencies.
go.sum	Records updated dependency checksums.
README.md	Major documentation rewrite with expanded examples and API details.
tag.go	Refactors struct-tag parsing; adds required/positional support and validation.
tag_test.go	Adds unit tests for new tag parsing behavior.
parser/attribute.go	Changes AST representation (Object/Array as *Attributes) and updates Build/PrepareAny.
parser/errors.go	Moves parse errors to span-based reporting and adds matcher-related sentinel errors.
parser/item.go	Adds ParserItem with rollback support for matcher/parser helpers.
parser/lexer.go	Adds snapshot/rollback support and spans; changes lexer input handling.
parser/lexer_test.go	Expands lexer tests for spans, rollback, and edge cases.
parser/matcher.go	Adds matcher helpers used by parser/item infrastructure and tests.
parser/parser.go	Rewrites parser around the new AST model, positional args, and better comma/closure handling.
parser/parser_test.go	Large expansion of parser/value/token/span/matcher tests.
parser/span.go	Introduces SourceSpan utilities.
parser/strings.go	Adds identifier validation helper used by tag parsing.
parser/token.go	Adds helper methods on Token (error check, OneOf, etc.).
parser/value.go	Adds typed accessors/converters and span-aware errors.

Comments suppressed due to low confidence (1)

tag.go:101

• parseAttribsTagDisabled is currently unused in the repo (no call sites found). If it’s not needed, consider removing it to reduce maintenance surface; otherwise add/retain a call site or a test that justifies keeping it.

func parseAttribsTagDisabled(tag string) (result bool, _ error) {
	parsed, err := parser.Parse(strings.NewReader(tag))
	if err != nil {
		return result, err
	}

	if parsed.Object == nil {
		return result, nil
	}

	for _, attr := range parsed.Object.Attributes {
		switch attr.Name {
		case "disabled":
			if result, err = attr.Value.AsBool(); err != nil {
				return result, fmt.Errorf("%w: disabled not boolean", err)
			}
		default:
			continue
		}
	}

	return result, nil
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.