relaxonVelocities branch: correcting lifetimes & viscosity iiii contributions written to hdf5#273
Open
elliotperviz wants to merge 1 commit into
Open
Conversation
…nd move viscosity iiii contribution out of i,j for loops to be called once per relaxon mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small changes:
-> means that kappa or viscosity contributions reconstructed using relaxon transport properties (written during output to hdf5) match within numerical tolerance the kappa / viscosity contributions (and totals) written to json.
Note that in i), the division by 2pi is only performed if isPhonon() evaluates to true. Right now I only have phonon BTE inputs/outputs at hand, so I did not check in my calculations if the same issue exists for the electronBTE. Probably the twoPi division should be applied in both cases.