Fix: Linux clipboard fallback skips xsel when xclip is not installed#4
Open
TofuGG wants to merge 1 commit into
Open
Fix: Linux clipboard fallback skips xsel when xclip is not installed#4TofuGG wants to merge 1 commit into
TofuGG wants to merge 1 commit into
Conversation
Refactor clipboard handling for better error management and support for Linux commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On Linux,
copy_to_clipboard()triedxclipandxselas fallbacks inside a single sharedtry/exceptblock. Ifxclipwasn't installed, theFileNotFoundErrorit raised escaped the loop and was caught by the outer handler — meaningxselwas never tried. Users withxselbut notxclip(common on Debian/Ubuntu) would silently fail to copy even though a working tool was present.The fix wraps each command in its own
try/exceptinside the loop, so a missing tool justcontinues to the next candidate. The macOS and Windows branches are also given their owntry/exceptblocks for the same reason.Three regression tests are added covering: xsel succeeding when xclip is absent, xclip succeeding when xsel is absent, and
Falsereturned cleanly when neither tool is installed.Related issue
No related issue.
Checklist
make test)[Unreleased]