fix(docs): document Mode-B ## Files exclusion-cue caveat in /pharn-plan - #137
Conversation
A bare narrative line under ## Files can truncate writes-scope; name the trap and the three safe patterns, and bump SKILLS_VERSION to 2.5.3. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 33 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis documentation-only change clarifies fail-closed ChangesMode-B exclusion-cue documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/commands/pharn-plan.md:
- Around line 240-242: Update the placeholder guidance in the touched-heading
rule to show an angle-bracket path as a list item matching pathsFromPlanFiles,
such as “- `<path>`”, and explicitly state that a bare “- `path`” item is unsafe
because it parses as a real scope path.
In @.dev/features/f13-modeb-cue/GRILL.md:
- Around line 48-60: Reconcile the final scope with the grill gate: in
.dev/features/f13-modeb-cue/GRILL.md lines 48-60, review README.md or record an
approved post-grill scope amendment; in lines 71-82, update the summary and
verdict to cover the final scope; and in .dev/features/f13-modeb-cue/SHIP.md
lines 18-30, rerun the grill or record the required human approval before
closing the chain.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3794458d-ce2d-43f2-9e07-6875f07aafff
📒 Files selected for processing (12)
.claude/commands/pharn-plan.md.dev/features/f13-modeb-cue/GRILL.md.dev/features/f13-modeb-cue/PLAN.md.dev/features/f13-modeb-cue/REGRESSION.md.dev/features/f13-modeb-cue/REVIEW.md.dev/features/f13-modeb-cue/SHIP.md.dev/features/f13-modeb-cue/VERIFY.md.dev/features/f13-modeb-cue/regression-report.json.dev/features/f13-modeb-cue/verify-report.jsonCHANGELOG.mdREADME.mdSKILLS_VERSION
| - **P3 (one axis of change / no sibling imports):** the three touched files (`pharn-plan.md`, | ||
| `CHANGELOG.md`, `SKILLS_VERSION`) are one coherent change-reason (documenting a caveat + its mandatory | ||
| version/changelog bookkeeping under this repo's own SKILLS_VERSION discipline) — not two unrelated | ||
| reasons bundled. No sibling-module reference is introduced; a command doc is not part of the | ||
| `pharn-contracts` layer tree. | ||
| - **P5 (determinism):** both prior open questions (option A vs B; the 2.5.1-vs-2.5.2 version-base | ||
| discrepancy) were resolved by asking the human at GATE 1, not guessed. The plan's own remaining | ||
| branches (which file gets which edit) are fixed, not classified. | ||
| - **P7 (honest scope / no speculation):** the plan explicitly excludes touching | ||
| `set-writes-scope.cjs` (option B) and `pharn-dev-plan.md` (no parity edit requested by the build | ||
| prompt) under `### Explicitly not touched`, with reasons — the smallest coherent increment, not two | ||
| bundled. The lesson L18 citation is genuinely on-point (same code path, adjacent failure mode), not a | ||
| padded citation. |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Reconcile the final scope with the grill gate.
The final plan contains README.md, but the grill analyzes only three files. The shipment record confirms that the file was added after the grill and that no grill rerun occurred.
.dev/features/f13-modeb-cue/GRILL.md#L48-L60: reviewREADME.mdor record an approved post-grill scope amendment..dev/features/f13-modeb-cue/GRILL.md#L71-L82: update the summary and verdict to cover the final scope..dev/features/f13-modeb-cue/SHIP.md#L18-L30: rerun the grill or record the required human approval before closing the chain.
📍 Affects 2 files
.dev/features/f13-modeb-cue/GRILL.md#L48-L60(this comment).dev/features/f13-modeb-cue/GRILL.md#L71-L82.dev/features/f13-modeb-cue/SHIP.md#L18-L30
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.dev/features/f13-modeb-cue/GRILL.md around lines 48 - 60, Reconcile the
final scope with the grill gate: in .dev/features/f13-modeb-cue/GRILL.md lines
48-60, review README.md or record an approved post-grill scope amendment; in
lines 71-82, update the summary and verdict to cover the final scope; and in
.dev/features/f13-modeb-cue/SHIP.md lines 18-30, rerun the grill or record the
required human approval before closing the chain.
1 participant
Summary
## Filescan trigger Mode-B's exclusion-cue fallback and silently truncate the authorized writes-scope.### Explicitly not touched) and clarifies that non-path lines under## Filesare not harmless.SKILLS_VERSIONto2.5.3(patch) with matching README badge and CHANGELOG entry; includes the f13-modeb-cue audit trail.Test plan
npm test/npm run checkstay green (verify already recorded PASS).claude/commands/pharn-plan.mdMode-B## Filesblockquote reads clearly next to the three existing parse rulesSKILLS_VERSIONboth read2.5.3set-writes-scope.cjs(docs-only clarification)Made with Cursor
Summary by CodeRabbit