chore(SEC-10670): upgrade basic-ftp to 5.3.1#40
Draft
phantom-autopilot[bot] wants to merge 1 commit intodevfrom
Draft
Conversation
Pin basic-ftp to 5.3.1 via resolutions (yarn) and overrides (pnpm) to mitigate GHSA-rpmf-866q-6p89 (CVE-2026-44240). The package is pulled in transitively through get-uri@^6.0.1 with range ^5.0.2; 5.3.1 satisfies that range and contains the fix for the unbounded multiline control response buffering DoS.
Author
|
PR opened by agent |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a new dependency resolution for basic-ftp (version 5.3.1) to both the resolutions and overrides sections of package.json, ensuring a consistent version is used across the project's dependency tree. ChangesDependency Resolution Configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the transitive
basic-ftpdependency to 5.3.1 to address GHSA-rpmf-866q-6p89 / CVE-2026-44240.basic-ftpallows a malicious FTP server to cause client-side denial of service via unbounded multiline control response buffering. The fix is in 5.3.1.Implementation
basic-ftpis pulled in transitively byget-uri@^6.0.1(via the proxy / Cypress dependency chain) with range^5.0.2.5.3.1satisfies that range.resolutions(yarn — used by CI) andoverrides(pnpm — used by some local scripts) so any downgrade to a vulnerable version is blocked.yarn.lockregenerated so installs resolve to the safe version.pnpm-lock.yamlnot regenerated to avoid a large unrelated diff caused by a newer pnpm rewriting the file format. Theoverridesentry inpackage.jsonensures any futurepnpm installresolves to 5.3.1.Verification
yarn why basic-ftp→basic-ftp@npm:5.3.1 (via npm:5.3.1)yarn installsucceeds.helpers.js,plugins/index.js,support/index.js) pre-date this change and are out of scope per the ticket.Linear
SEC-10670
Test plan
basic-ftpto5.3.1🤖 Generated with Claude Code
Summary by CodeRabbit