Skip to content

Suncycle/suncycle#2158 v15 suncycle 1#275

Merged
alibaig4u merged 4 commits into
suncycle-version-15from
suncycle/suncycle#2158_v15_suncycle_1
Jun 5, 2026
Merged

Suncycle/suncycle#2158 v15 suncycle 1#275
alibaig4u merged 4 commits into
suncycle-version-15from
suncycle/suncycle#2158_v15_suncycle_1

Conversation

@sonalimandarnarkar

@sonalimandarnarkar sonalimandarnarkar commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Parent : https://git.phamos.eu/suncycle/suncycle/-/issues/2158
Issue : https://git.phamos.eu/suncycle/suncycle/-/work_items/2220

Description :
This pull request introduces a new GitHub Actions workflow for running Workday unit tests and refactors the Weekly Working Hours client-side logic to improve maintainability and user experience. Additionally, it removes obsolete server-side logic related to break minutes calculation, centralizing this responsibility in the client code.

Workflow automation:

  • Adds a .github/workflows/workday-tests.yml workflow to automate Workday unit tests on relevant branches, including setup for dependencies like MariaDB, Redis, and Frappe Bench, and provides a detailed test summary in the GitHub Actions UI.

Client-side improvements for Weekly Working Hours:

  • Refactors weekly_working_hours.js to dynamically show or hide the break_minutes column in the child table based on the break calculation mechanism setting, using new helper functions for style injection and grid column management. This improves the user interface and ensures consistency with configuration.
  • Ensures that the visibility of the break_minutes column is updated on form load, refresh, and child table rendering, and synchronizes the field's hidden state in both the grid and metadata.

Server-side code cleanup:

  • Removes the logic for automatically setting and validating break minutes in weekly_working_hours.py, including the _get_rule_break_minutes and set_break_hours_if_not_set methods, as this is now handled on the client side.
  • Cleans up unused imports in weekly_working_hours.py to reflect the simplified logic.

@sonalimandarnarkar sonalimandarnarkar changed the base branch from version-15 to suncycle-version-15 June 5, 2026 09:28
@alibaig4u alibaig4u merged commit 099ca74 into suncycle-version-15 Jun 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants