Suncycle/suncycle#2158 v15 suncycle 1#275
Merged
alibaig4u merged 4 commits intoJun 5, 2026
Merged
Conversation
alibaig4u
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent : https://git.phamos.eu/suncycle/suncycle/-/issues/2158
Issue : https://git.phamos.eu/suncycle/suncycle/-/work_items/2220
Description :
This pull request introduces a new GitHub Actions workflow for running Workday unit tests and refactors the
Weekly Working Hoursclient-side logic to improve maintainability and user experience. Additionally, it removes obsolete server-side logic related to break minutes calculation, centralizing this responsibility in the client code.Workflow automation:
.github/workflows/workday-tests.ymlworkflow to automate Workday unit tests on relevant branches, including setup for dependencies like MariaDB, Redis, and Frappe Bench, and provides a detailed test summary in the GitHub Actions UI.Client-side improvements for Weekly Working Hours:
weekly_working_hours.jsto dynamically show or hide thebreak_minutescolumn in the child table based on the break calculation mechanism setting, using new helper functions for style injection and grid column management. This improves the user interface and ensures consistency with configuration.break_minutescolumn is updated on form load, refresh, and child table rendering, and synchronizes the field's hidden state in both the grid and metadata.Server-side code cleanup:
weekly_working_hours.py, including the_get_rule_break_minutesandset_break_hours_if_not_setmethods, as this is now handled on the client side.weekly_working_hours.pyto reflect the simplified logic.