Remove the old parser's AST from StatementRewrite#1182
Conversation
It is no longer used, so we can get rid of it. I opted to change the signature of `maybe_rewrite` to take a mutable reference to the statement rather than copy it and return a new one. This resulted in a significant indentation change, but no actual code changes (beyond replacing a few `as_ref` and `as_mut`s with `stmt` and `stmt_mut`.
levkk
left a comment
There was a problem hiding this comment.
This is because we couldn't mutate ASTs before, right? Nice. Bye bye pg_query, say hello to sage_query. No qualms with you naming the library after yourself.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
No, we could. It's purely a question of where |
It is no longer used, so we can get rid of it. I opted to change the signature of
maybe_rewriteto take a mutable reference to the statement rather than copy it and return a new one. This resulted in a significant indentation change, but no actual code changes (beyond replacing a fewas_refandas_muts withstmtandstmt_mut.