Extract the assembler into a reusable xasm library - #15
Open
epi wants to merge 10 commits into
Open
Conversation
pfusik
requested changes
Sep 1, 2026
pfusik
left a comment
pfusik
left a comment
Owner
There was a problem hiding this comment.
Thank you for doing this! Generally LGTM with a few nits, and I think -i got broken.
| return options[letter - 'a']; | ||
| } | ||
|
|
||
| enum Severity { warning, error } |
Owner
There was a problem hiding this comment.
This only makes the code more verbose than a bool.
|
|
||
| enum Severity { warning, error } | ||
|
|
||
| struct Diagnostic { |
Owner
There was a problem hiding this comment.
Why this struct and not pass directly?
Comment on lines
+189
to
+190
| int line; | ||
| string sourceLine; |
Owner
There was a problem hiding this comment.
Please use lineNo/line consistently.
| } | ||
|
|
||
| alias SourceReader = immutable(ubyte)[] delegate(string path); | ||
| alias BinaryReader = immutable(ubyte)[] delegate(string path, long offset, long length); |
| } | ||
|
|
||
| File openInputFile(string filename) { | ||
| void recordSource(string filename) { |
|
|
||
| void writeLabelTable() { | ||
| string filename = optionParameters['t' - 'a']; | ||
| if (filename !is null && listingStream.isOpen && listingStream != stdout) |
| } | ||
|
|
||
| version (unittest) ubyte[] objectBuffer; | ||
| Appender!(ubyte[]) objectBuffer; |
| if (inFalseCondition() && !listFalseConditionals) | ||
| return; | ||
| if (!getOption('i') && includeLevel > 0) | ||
| if (!listIncludedFiles && includeLevel > 0) |
Owner
There was a problem hiding this comment.
The other two uses of listIncludedFiles already do the logical negation.
| int value; /// The value assigned to the label. | ||
| bool unused = true; /// True until the label is referenced somewhere. | ||
| bool unknownInPass1 = false; /// True if the value was not yet known during pass 1. | ||
| bool passed = false; /// True once the label's definition has been processed. |
Owner
There was a problem hiding this comment.
"was encountered in the current pass"
|
|
||
| } | ||
|
|
||
| /// |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors xasm so the assembler core can be used as a library (
libxasm) from any D program, not just through thexasmcommand-line tool.xebinis going to be its first user.All the assembly logic previously living in
source/app.dnow sits behind anAssemblerclass in a newsource/xasm/package.dmodule.app.dbecomes a thin CLI frontend that drives that class.What changed
xasmmodule (source/xasm/package.d): the assembler implementation, moved out ofapp.dverbatim and wrapped in anAssemblerclass with a private implementation and a small public surface.SourceReader/BinaryReader— read source and binary-include filesDiagnosticSink— receive warnings and errors as structuredDiagnosticvalues (Severity, filename, line, source line, message)ListingSink— receive the assembly listing and label table line by lineassembler.object, instead of being written straight to a file.make libxasm.htmlgenerates the library reference.Labelis now astruct, and the module carries a documented usage example (runnable as a unittest).Notes