Move base-class hash table teardown from dispose() to finalize()#62
Merged
Conversation
Copilot created this pull request from a session on behalf of
havardgraff
June 16, 2026 11:00
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the base-class hash table teardown for
GstElementandGstBinout ofdispose()and intofinalize().Changes
subprojects/gstreamer/gst/gstelement.c: Move hash table teardown fromdispose()tofinalize().subprojects/gstreamer/gst/gstbin.c: Move hash table teardown fromdispose()tofinalize().Since
dispose()can be called multiple times during an object's lifetime, performing the hash table teardown there can lead to issues.finalize()is only ever called once, making it the correct place for this cleanup.