Skip to content

remove #[inline] on lambdas - #219

Merged
dragostis merged 1 commit into
pest-parser:masterfrom
kivikakk:remove-lambda-inlines
Mar 31, 2018
Merged

remove #[inline] on lambdas#219
dragostis merged 1 commit into
pest-parser:masterfrom
kivikakk:remove-lambda-inlines

Conversation

@kivikakk

Copy link
Copy Markdown
Contributor

Fixes #218.

Per rust-lang/rust#49291 (comment), #[inline] has no effect on lambdas, and rustc has stopped allowing this in nightly.

Signed-off-by: Ashe Connor <ashe@kivikakk.ee>
@kivikakk

Copy link
Copy Markdown
Contributor Author

I'd like to test that this actually fixes the problem locally, but it's unclear to me quite how to do that. (do I set up an alternate registry?? that sounds like Not Fun.)

@Kroisse

Kroisse commented Mar 31, 2018

Copy link
Copy Markdown

I think it can be proven by compiling it.

https://github.com/pest-parser/pest/blob/master/grammars/src/lib.rs#L20-L32

@kivikakk

Copy link
Copy Markdown
Contributor Author

I'm not sure how that helps: on rust nightly, it attempts to build meta, which uses pest_derive 1.0.6, which doesn't have this change, so the resulting generated code fails.

@Kroisse

Kroisse commented Mar 31, 2018

Copy link
Copy Markdown

I've tried that by adding [patch.crates-io] section to use the local version of pest_derive, but it's failed because pest_derive is depends on pest_meta so they make a circular dependency.

I think that is the only solution releasing 1.0.7 with this patch. It's possible because it still can be compiled on rustc 1.25 stable.

@dragostis dragostis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Kroisse

Kroisse commented Mar 31, 2018

Copy link
Copy Markdown

@kivikakk I've tried to fix on v1.0.6 instead master and it works.

@dragostis
dragostis merged commit 265f8b5 into pest-parser:master Mar 31, 2018
@kivikakk
kivikakk deleted the remove-lambda-inlines branch March 23, 2023 07:54
@kivikakk
kivikakk restored the remove-lambda-inlines branch March 23, 2023 07:54
@kivikakk
kivikakk deleted the remove-lambda-inlines branch March 23, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants