Skip to content

fix: validate Ed25519 key type and specify explicit algorithm (Fixes #52) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeroknowledge0x wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate Ed25519 key type and specify explicit algorithm (Fixes #52) #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,21 @@ export async function verifyReceipt(receipt: unknown, options: VerifyOptions): P
};
}

// Validate that the resolved key is actually an Ed25519 key
const keyType = keyResult.key.asymmetricKeyType;
if (keyType !== 'ed25519') {
return {
verified: false,
exitCode: 1,
errorCode: 'SIGNATURE_INVALID',
errorMessage: `key type mismatch: receipt declares ed25519 but resolved key is ${keyType}`,
receiptId: receipt.id as string,
};
}

const payloadBytes = canonicalizeReceiptBytes(receipt);
const signatureBytes = Buffer.from(receipt.signatureValue, 'base64');
const ok = verifySignature(null, payloadBytes, keyResult.key, signatureBytes);
const ok = verifySignature('ed25519', payloadBytes, keyResult.key, signatureBytes);

if (!ok) {
return {
Expand Down