Skip to content

fix: prevent panic on non-MySQL errors in PopulateGroupReplicationInformation #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackiesre721 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent panic on non-MySQL errors in PopulateGroupReplicationInformation #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions go/inst/instance_dao.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3468,15 +3468,14 @@ func PopulateGroupReplicationInformation(instance *Instance, db *sql.DB) error {
`
rows, err := db.Query(q)
if err != nil {
_, grNotSupported := GroupReplicationNotSupportedErrors[err.(*mysql.MySQLError).Number]
if grNotSupported {
return nil // If GR is not supported by the instance, just exit
} else {
// If we got here, the query failed but not because the server does not support group replication. Let's
// log the error
return log.Errorf("There was an error trying to check group replication information for instance "+
"%+v: %+v", instance.Key, err)
var mysqlErr *mysql.MySQLError
if errors.As(err, &mysqlErr) {
if _, ok := GroupReplicationNotSupportedErrors[mysqlErr.Number]; ok {
return nil // If GR is not supported by the instance, just exit
}
}
return log.Errorf("There was an error trying to check group replication information for instance "+
"%+v: %+v", instance.Key, err)
}
defer rows.Close()
foundGroupPrimary := false
Expand Down