Skip to content

Drop Newtonsoft Unity assembly references #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
penspanic merged 1 commit into from
Jun 12, 2026
Merged

Drop Newtonsoft Unity assembly references #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Datra.SampleData/Datra.SampleData.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@
"allowUnsafeCode": false,
"overrideReferences": true,
"precompiledReferences": [
"Newtonsoft.Json.dll",
"YamlDotNet.dll"
],
"autoReferenced": true,
"defineConstraints": [],
"versionDefines": [],
"noEngineReferences": false
}
}
2 changes: 1 addition & 1 deletion Datra/Converters/PolymorphicYamlSupport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
namespace Datra.Converters
{
/// <summary>
/// Resolves type names to Type objects, similar to PortableTypeBinder for JSON.
/// Resolves type names to Type objects for legacy YAML polymorphism.
/// Enables YAML portability across different assembly configurations.
/// </summary>
public class PortableTypeResolver
Expand Down
3 changes: 1 addition & 2 deletions Datra/Datra.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,10 @@
"allowUnsafeCode": false,
"overrideReferences": true,
"precompiledReferences": [
"Newtonsoft.Json.dll",
"YamlDotNet.dll"
],
"autoReferenced": true,
"defineConstraints": [],
"versionDefines": [],
"noEngineReferences": false
}
}
2 changes: 1 addition & 1 deletion Datra/Repositories/DeepCloner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ private static JsonSerializerOptions CreateOptions()
var opts = new JsonSerializerOptions
{
DefaultIgnoreCondition = System.Text.Json.Serialization.JsonIgnoreCondition.WhenWritingNull,
// Match Newtonsoft round-trip semantics: Datra data classes occasionally expose
// Match Datra's legacy round-trip semantics: Datra data classes occasionally expose
// public fields (e.g. PooledPrefab.Path). STJ excludes fields by default — turning
// it on keeps DeepCloner.Clone behaviourally compatible.
IncludeFields = true,
Expand Down
2 changes: 1 addition & 1 deletion Datra/Serializers/DatraJsonHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
namespace Datra.Serializers
{
/// <summary>
/// STJ option helpers that re-create Datra's Newtonsoft-era contract semantics.
/// STJ option helpers that re-create Datra's legacy JSON contract semantics.
/// </summary>
internal static class DatraJsonHelpers
{
Expand Down
Loading