Migrate to shared-actions#223
Open
vsingh18567 wants to merge 2 commits into
Open
Conversation
joyliu-q
reviewed
Oct 5, 2023
joyliu-q
left a comment
joyliu-q
left a comment
Contributor
There was a problem hiding this comment.
Added some minor comments! Thanks for making this :D
| @@ -0,0 +1,24 @@ | |||
| # Generated by cdkactions. Do not modify | |||
Contributor
There was a problem hiding this comment.
Let's delete these two top lines and sub in:
# ========================================
# Note: If you make changes to this CI/CD, please include someone from DevOps in the list of reviewers for the PR.
# ========================================
| name: React Check & Publish Frontend | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: pennlabs/shared-actions/.github/workflows/react.yaml@main |
Contributor
There was a problem hiding this comment.
Rather than pinning to main, let's do a specific version or hash (see penn-clubs example)
I just released the new changes you made to shared-actions, so we can start using v0.1.2
anli5005
force-pushed
the
update-to-shared-actions
branch
from
d2fd4de to
df076e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.