[Janitor] fix(cmd): use RunE to propagate write errors from version command#58
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Janitor] fix(cmd): use RunE to propagate write errors from version command#58github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Previously, newVersionCmd used Run and silently discarded write errors with _, _. Switch to RunE so errors from fmt.Fprintln are wrapped and returned to the caller, letting cobra report them and exit non-zero. Also adds TestVersionCommandPropagatesWriteError to cover the error path, restoring internal/cmd coverage to 100%. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
newVersionCmdusedRunand silently discarded write errors with_, _. This meant that if writing to stdout failed (e.g. broken pipe), the command would exit 0 with no error message.Changes:
newVersionCmdfromRuntoRunE, wrapping anyfmt.Fprintlnerror with context ("print version: %w")TestVersionCommandPropagatesWriteErrorto exercise the error path, restoringinternal/cmdcoverage to 100% (total: 92.3%)All tests pass,
golangci-lintreports 0 issues.