[Janitor] test(cmd): strengthen root command tests with table-driven approach#44
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[Janitor] test(cmd): strengthen root command tests with table-driven approach#44github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
- Replace two separate test functions with a single table-driven TestRootCommand - Add test for --version flag (cobra built-in, previously untested) - Add test for unknown command error path - Strengthen help assertion to verify 'myapp' appears in output - Use SetErr to capture error output in the same buffer Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
internal/cmd/root_test.goto use a single table-driven test covering all root command behaviors, including a previously untested code path.Changes:
TestRootExecutesandTestVersionCommandinto one table-drivenTestRootCommand--versionflag (cobra built-in, was not covered)--helpassertion to verify"myapp"appears in output (was only checking non-empty)No behavior changes — tests only.