fix(kyc): route email-blocked gates to the self-serve email sheet consistently (final /code-review)#2344
Merged
Merged
Conversation
…sistently (final /code-review) Final pre-prod review of the #2342 provide-email surfaces found two consumer sites diverging from the canonical deriveGate order (email-blocked > fixable): - ActivationCTAs: the copy memo ranked hasFixableRejection above isEmailBlocked while the button onClick ranked isEmailBlocked first — so with both rail states the card said 'Upload document' but opened the email sheet, and hid the document path. Reordered the memo (+ primaryRejectionMessage) to email-blocked → fixable → terminal, matching onClick and deriveGate. - AddWithdrawCountriesList.handleFormSubmit: missing the provide-email branch that checkBridgeGate has, so a rail flipping to email-blocked between form-open and submit opened the contact-support KYC modal instead of the email sheet — the exact self-serve→support-ticket regression #2342 fixes. Added the branch; regression test pins provide-email → sheet, not modal. Follow-up (not blocking): ActivationCTAs re-implements gate ordering inline; it should consume deriveGate directly so consumers can't drift again. Full suite 1675 green; typecheck clean.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
Contributor
Code-analysis diffPainscore total: 5872.35 → 5872.71 (+0.36) 🆕 New findings (10)
✅ Resolved (10)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final pre-prod
/code-reviewof the #2342 provide-email surfaces found two consumer sites diverging from the canonicalderiveGateorder (email-blocked > fixable-rejection):hasFixableRejectionaboveisEmailBlockedwhile the button onClick rankedisEmailBlockedfirst — so with both rail states the card read 'Upload document' but opened the email sheet, and hid the document path. Reordered the memo (+primaryRejectionMessage) to email-blocked → fixable → terminal, matching the onClick and canonicalderiveGate.provide-emailbranch thatcheckBridgeGatehas, so a rail flipping to email-blocked between form-open and submit opened the contact-support KYC modal instead of the email sheet — the exact self-serve→support-ticket regression feat(kyc): provide-email sheet for the no-email verification dead-end #2342 exists to fix. Added the branch; regression test pins provide-email → sheet, not modal.The 3rd review finding (poll 5s→60s recovery latency) is the documented, intentional tradeoff the review itself ranked last as not-a-bug — accepted.
Follow-up (not blocking)
ActivationCTAs re-implements the gate ordering inline; it should consume
deriveGatedirectly so consumers can't drift again.QA
Full jest suite 1675 green; typecheck clean; new regression test for the bank-submit provide-email routing.