chore: back-merge main → dev (offramp migration deposit + invite fixes)#2343
Merged
Conversation
offramp.xyz is shutting down and migrating users to peanut. give offramp migrants a de-cluttered arbitrum deposit surface instead of the full multi-chain crypto picker: same rhino EVM SDA (funds land on the peanut arbitrum wallet), but stripped to a single arbitrum + usdc view with offramp copy. - gate a 'migrate from offramp' entry on the offramp badge (placeholder code, wired to the real badge once that PR lands) - deep-link /add-money/crypto?network=EVM&source=offramp drives a new 'offramp' variant of the crypto deposit view - tag completions as offramp_migration for the growth dashboard reuses the existing SDA creation, polling and success screen unchanged.
badge PRs (peanut-api-ts#1105, peanut-ui#2331) landed the link-granted OFFRAMP_USER badge; wire the deposit-entry gate to it.
?campaign=offramp (and any UTM-mapped vanity tag passed via the explicit campaign/campaignTag param) reached /badge/award raw and 400'd, since the backend matches the badge code. Resolve it through the UTM map first so the offramp migration link grants OFFRAMP_USER regardless of link shape. depends on peanut-ui#2331 (adds the offramp UTM map entry) reaching this base.
…ted campaign resolution Code-review + UX pass findings: - pin network to EVM when source=offramp: a shared ?network=SOL&source=offramp link previously created a Solana deposit address rendered under Arbitrum-only labels — funds-confusion class - migration-aware terminal states: success header 'Migration Complete', receipt fallbacks USDC/Arbitrum (was USDT + Ethereum icon when Rhino omits token/chain), failed-state copy points migrants back to their Offramp account instead of 'market moved / back to your wallet' - retryable error state when deposit-address creation fails (was: screen instructs 'send USDC' with no address rendered at all — applies to the default crypto flow too) - offramp-specific How to Migrate steps (generic modal said 'select one of the supported networks' — contradicting the single-network migration screen) - 'Migration deposit address' + reuse-warning tooltip (was 'Your Arbitrum address', teaching users to save a constrained bridge endpoint as their wallet), per-transfer limit labels + split-into-parts hint - post-claim routing: logged-in offramp claimants land on the migration screen, not /home - campaign resolution extracted to resolveCampaign() in campaign-maps.ts with unit tests — encodes ?campaign= ≡ ?utm_campaign= deliberately; shared OFFRAMP_BADGE_CODE so the entry gate can't drift from the maps
…eposit-main feat(add-money): offramp migration deposit entry
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Comment |
Contributor
Code-analysis diffPainscore total: 5867.29 → 5872.35 (+5.06) 🆕 New findings (17)
✅ Resolved (14)
📈 Painscore deltas (top movers)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the 4 offramp/invite commits that landed on main (add-money offramp migration deposit entry #2333 + review fixes, lowercase vanity-tag resolution, real OFFRAMP_USER badge code) back into dev so the dev→main release #2340 stays a clean superset.
Textually clean merge (zero overlap with the release payload). Typecheck + 1674 jest tests green on the merged tree.
Risks
None — pure sync of already-merged, already-in-prod main commits. No new code.
QA
Local gate: typecheck ✅, jest 1674 ✅ (108 suites).