-
Notifications
You must be signed in to change notification settings - Fork 14
refactor(assets): name the mascot a mascot, not a logo #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| export { default as PEANUT_LOGO } from './peanut-logo.svg'; | ||
| export { default as PEANUT_LOGO_BLACK } from './peanut-logo-dark.svg'; | ||
| export { default as MEPA_ARGENTINA_LOGO } from './mepa-arg.svg'; | ||
| export { default as PIX_BRZ_LOGO } from './pix-brz.svg'; | ||
| export { default as DEVCONNECT_LOGO } from './devconnect.svg'; |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -42,7 +42,7 @@ import { evmChainIdToRhinoName } from '@/constants/rhino.consts' | |||||
| import { getTokenSymbol } from '@/utils/general.utils' | ||||||
| import { Button } from '@/components/0_Bruddle/Button' | ||||||
| import Image from 'next/image' | ||||||
| import { PEANUT_LOGO_BLACK, PEANUTMAN_LOGO } from '@/assets' | ||||||
| import { PEANUT_LOGO_BLACK, PEANUTMAN } from '@/assets' | ||||||
| import { GuestVerificationModal } from '@/components/Global/GuestVerificationModal' | ||||||
| import { useCapabilities } from '@/hooks/useCapabilities' | ||||||
| import MantecaFlowManager from './MantecaFlowManager' | ||||||
|
|
@@ -822,7 +822,7 @@ export const InitialClaimLinkView = (props: IClaimScreenProps) => { | |||||
| <div className="flex items-center gap-1"> | ||||||
| <div>Receive on </div> | ||||||
| <div className="flex items-center gap-1"> | ||||||
| <Image src={PEANUTMAN_LOGO} alt="Peanut Logo" className="size-5" /> | ||||||
| <Image src={PEANUTMAN} alt="Peanut Logo" className="size-5" /> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Alt text still says "logo" despite PR's stated rename intent. The PR objective states the mascot alt text should change from ✏️ Proposed fix- <Image src={PEANUTMAN} alt="Peanut Logo" className="size-5" />
+ <Image src={PEANUTMAN} alt="Peanut mascot" className="size-5" />📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| <Image src={PEANUT_LOGO_BLACK} alt="Peanut Logo" /> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| 'use client' | ||||||
|
|
||||||
| import { PEANUTMAN_LOGO } from '@/assets/mascot' | ||||||
| import { PEANUTMAN } from '@/assets/mascot' | ||||||
| import { useEffect, useState } from 'react' | ||||||
| import { PAYMENT_LOADING_WORDS } from './words' | ||||||
|
|
||||||
|
|
@@ -26,7 +26,7 @@ export default function CyclingLoading() { | |||||
| <div className="w-full flex-col items-center justify-center self-center text-center"> | ||||||
| <div className="flex w-full items-center justify-center self-center"> | ||||||
| <div className="animate-spin"> | ||||||
| <img src={PEANUTMAN_LOGO.src} alt="logo" className="h-10" /> | ||||||
| <img src={PEANUTMAN.src} alt="logo" className="h-10" /> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Alt text not updated to "Peanut mascot". Per the PR objective, mascot alt text should change from 💚 Proposed fix- <img src={PEANUTMAN.src} alt="logo" className="h-10" />
+ <img src={PEANUTMAN.src} alt="Peanut mascot" className="h-10" />📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| <span className="sr-only">{word}</span> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||
| import { PEANUTMAN_LOGO } from '@/assets' | ||||||
| import { PEANUTMAN } from '@/assets' | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Barrel import violates project convention. ESLint flags this: importing 🔧 Proposed fix-import { PEANUTMAN } from '`@/assets`'
+import { PEANUTMAN } from '`@/assets/mascot`'📝 Committable suggestion
Suggested change
🧰 Tools🪛 ESLint[error] 1-1: ' (no-restricted-imports) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||||||
| import { twMerge } from 'tailwind-merge' | ||||||
|
|
||||||
| export default function PeanutLoading({ | ||||||
|
|
@@ -18,7 +18,7 @@ export default function PeanutLoading({ | |||||
| )} | ||||||
| > | ||||||
| <div className={twMerge('animate-spin')}> | ||||||
| <img src={PEANUTMAN_LOGO.src} alt="logo" className="h-10" /> | ||||||
| <img src={PEANUTMAN.src} alt="Peanut mascot" className="h-10" /> | ||||||
| <span className="sr-only">{message ?? 'Loading...'}</span> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| 'use client' | ||
|
|
||
| import { HandThumbsUpV2, PEANUT_LOGO_BLACK, PEANUTMAN_LOGO } from '@/assets' | ||
| import { HandThumbsUpV2, PEANUT_LOGO_BLACK, PEANUTMAN } from '@/assets' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚀 Performance & Scalability | 🟠 Major | ⚡ Quick win Avoid the This still trips the repo’s restricted-imports rule and pulls in the broader asset re-export graph. Split the mascot/logo symbols onto their owning modules instead, and move 🧰 Tools🪛 ESLint[error] 3-3: ' (no-restricted-imports) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| import { Button } from '@/components/0_Bruddle/Button' | ||
| import { Icon } from '@/components/Global/Icons/Icon' | ||
| import NavHeader from '@/components/Global/NavHeader' | ||
|
|
@@ -76,7 +76,7 @@ const PublicProfile: React.FC<PublicProfileProps> = ({ username, isLoggedIn = fa | |
| <div> | ||
| {!isLoggedIn ? ( | ||
| <div className="flex items-center gap-2 md:hidden"> | ||
| <Image src={PEANUTMAN_LOGO} alt="Peanut Logo" height={24} /> | ||
| <Image src={PEANUTMAN} alt="Peanut mascot" height={24} /> | ||
| <Image src={PEANUT_LOGO_BLACK} alt="Peanut Text" height={12} /> | ||
| </div> | ||
| ) : ( | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -12,7 +12,7 @@ import { VerifiedUserLabel } from '../UserHeader' | |||||||||||||||||||||||
| import ProgressBar from '../Global/ProgressBar' | ||||||||||||||||||||||||
| import { useRouter } from 'next/navigation' | ||||||||||||||||||||||||
| import { twMerge } from 'tailwind-merge' | ||||||||||||||||||||||||
| import { PEANUTMAN_LOGO } from '@/assets/mascot' | ||||||||||||||||||||||||
| import { PEANUTMAN } from '@/assets/mascot' | ||||||||||||||||||||||||
| import { profileUrl } from '@/utils/native-routes' | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| interface TransactionDetailsHeaderCardProps { | ||||||||||||||||||||||||
|
|
@@ -210,7 +210,7 @@ export const TransactionDetailsHeaderCard: React.FC<TransactionDetailsHeaderCard | |||||||||||||||||||||||
| {isTestTransaction ? ( | ||||||||||||||||||||||||
| <div className="flex items-center gap-3"> | ||||||||||||||||||||||||
| <div> | ||||||||||||||||||||||||
| <Image src={PEANUTMAN_LOGO} alt="Peanut Logo" width={64} height={64} className="size-8" /> | ||||||||||||||||||||||||
| <Image src={PEANUTMAN} alt="Peanut Logo" width={64} height={64} className="size-8" /> | ||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||
|
Comment on lines
210
to
214
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Update the alt text to match the mascot rename. The image source was renamed, but the label still says “Logo.” Switch this to “Peanut mascot” so the header card stays consistent with the new naming. ♻️ Suggested tweak- <Image src={PEANUTMAN} alt="Peanut Logo" width={64} height={64} className="size-8" />
+ <Image src={PEANUTMAN} alt="Peanut mascot" width={64} height={64} className="size-8" />📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||
| <div> | ||||||||||||||||||||||||
| <h2 className="text-xl font-extrabold">Enjoy Peanut!</h2> | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Import from
@/assetsbarrel is lint-restricted.ESLint flags this as an error: importing from the
@/assetsbarrel forces loading every re-export and hurts build perf. Other files in this same PR (SendLinkActionList.tsx,QRScanner/index.tsx) already import from the specific submodules (@/assets/mascot,@/assets/logos) — this file should follow suit.🛠️ Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 ESLint
[error] 45-45: '
@/assets' import is restricted from being used. Import from a specific file instead of the '@/assets' barrel — barrels force the bundler to load every re-export and hurt build perf. See CLAUDE.md.(no-restricted-imports)
🤖 Prompt for AI Agents
Source: Linters/SAST tools