Skip to content

Stabilize dashboard locale validation #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pcvantol merged 2 commits into from
Aug 15, 2026
+14 −0
Merged

Stabilize dashboard locale validation #798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f8f88
Stabilize dashboard locale test
pcvantol Aug 8, 2026
42aabbe
Merge branch 'main' into codex/stabilize-dashboard-locale-ci
pcvantol Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/engineering/dashboard.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,21 @@ test.describe("Engineering Status browser smoke", () => {
);
// Change language only after the asynchronous snapshot has rendered;
// otherwise it may overwrite localized template placeholders.
// A locale selection deliberately reloads the dashboard so persisted
// client state is applied from a clean document. Wait for that specific
// navigation before inspecting template bindings; otherwise a fast CI
// worker can read the outgoing document while its localized text is
// being replaced.
const localeReload = page.waitForEvent(
"framenavigated",
(frame) => frame === page.mainFrame(),
);
await page.locator("#dashboardLocale").selectOption(language);
await localeReload;
await page.waitForLoadState("domcontentloaded");
await page.waitForFunction(
() => document.body.classList.contains("dashboard-ready"),
);
await expect(page.locator("html")).toHaveAttribute("lang", language);
await expect(page).toHaveTitle(sourceTranslator("dashboard.title"));
await expect(page.locator("#dashboardAppleWebAppTitle")).toHaveAttribute(
Expand Down