refactor: create invert tags helper - #224
Merged
Merged
Conversation
Owner
|
This LGTM I think! No strong feelings on jankiness :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors the existing transpose_tags helper and simplifies the logic in _solve.py. The main goal is unifying tags logic so if a developer adds a new tag (e.g. the proposed
circulant_tagfrom discussions with @BalzaniEdoardo) they don't need to trace as much of the codebase. The tags_from_checks helper is the most janky due to its circular import with_operatory.py(solved with lazy importing andTYPE_CHECKINGconditionals). Happy to move that to_operator.pyif you prefer.