refactor: single source of truth for Claude model families - #64
Merged
Conversation
The family list existed in three places: the formatModelName regexes, MODEL_FAMILY_CONTEXT, and MODEL_FAMILY_COST. Adding a family meant three lockstep edits across two files, and the formatter matched case-sensitively while the tables are documented as lower-cased. One CLAUDE_FAMILIES table now drives display names, context windows, and cost rates; the formatter regexes are built from it and match case-insensitively. Follow-up promised in #60.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Consolidates the Claude family list that existed in three places (the
formatModelNameregexes,MODEL_FAMILY_CONTEXT, andMODEL_FAMILY_COST) into oneCLAUDE_FAMILIEStable incanvas-constants.tsthat drives display names, context windows, and cost rates. Also makes the formatter match case-insensitively, consistent with the tables' documented lower-cased matching. No behavior change for existing model IDs. Follow-up promised in #60.How to test
pnpm test— includes two new tests: case-insensitive matching, and a loop asserting everyCLAUDE_FAMILIESentry is formattable.pnpm run build:web.Checklist