Sync upstream: fix import of Normal and Magic Ward bases#2
Merged
Conversation
The bases were not being imported as they were using a frame type value of 11 and 12 which were not in the rarity map so PoB just wouldn't import them Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev(1 new commit: Fix Normal and Magic Ward bases not importing PathOfBuildingCommunity/PathOfBuilding-PoE2#2383, fixes item-import rarity mapping for Normal/Magic Ward bases insrc/Classes/ImportTab.lua)ImportTab.lua; the macOS JIT patch only touchesLaunch.luaTest plan
jit.os == "OSX") inLaunch.luais unaffected by the merge