fix: raise the patchrail floor to 0.5.0 so the action stops annotating wrong answers - #7
Merged
Merged
Conversation
…g wrong answers The default range was `>=0.3.1,<0.5.0`, so every consumer of this action installs 0.4.0 — the last release that reads a tool the job merely *named* as the cause of death. On real logs that is not rare: a `GRADLE_HOME=` line in a Windows environment table diagnosed a Java build failure in an apache/kafka job that compiled nothing, and pip's `Collecting mypy==1.17.1` diagnosed a type-check failure in a job that never type-checked. This action's whole output is a confident one-line verdict written into someone's pull request, which is the worst possible place to be confidently wrong. patchrail 0.5.0 judges a signal by the line it lands on and answers `unknown` rather than inventing a cause. Floor raised to 0.5.0; the `<0.6.0` cap stays and keeps doing its job — 0.4.0 moved the `ci classes` JSON from v1 to v2 in a minor bump, which is exactly what the cap exists to hold back. Verified against PyPI, not a local build: `patchrail>=0.5.0,<0.6.0` resolves to 0.5.0, the suite passes against it, and `ci explain --format json` still emits `patchrail.ci_result.v1` — the contract annotate.py reads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default range
>=0.3.1,<0.5.0pins every consumer of this action to 0.4.0 — the last release that reads a tool the job merely named as the cause of death. AGRADLE_HOME=line in an environment table was enough to diagnose a Java build failure in an apache/kafka job that compiled nothing; pip'sCollecting mypywas enough to diagnose a type-check failure in a job that never type-checked.This action writes a confident one-line verdict into a pull request. That is the worst place to be confidently wrong, so the floor moves to 0.5.0, which judges a signal by the line it lands on and says
unknownrather than inventing a cause.The
<0.6.0cap stays: 0.4.0 moved theci classesJSON from v1 to v2 in a minor bump, which is precisely what the cap holds back.Verified against PyPI (not a local build)
patchrail>=0.5.0,<0.6.0resolves to 0.5.0ci explain --format jsonstill emitspatchrail.ci_result.v1, the contractannotate.pyreadsjava_build_failure@ 0.53 (wrong) · 0.5.0 →unknown@ 0.15 (honest). A real gradle failure still classifies asjava_build_failure@ 0.71.