ci: keep the v1 tag on the latest tested commit - #4
Merged
Conversation
Everyone pins patchrail/ci-triage-action@v1, but CI only ever tested the commit. The tag had fallen two commits behind main, so the guide-slug guard added in #3 was validating code that no user actually runs. Move v1 to each main commit that passes both jobs, and document in the README that v1 floats within the v1 line (with SHA pinning as the alternative).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everyone pins
patchrail/ci-triage-action@v1, but the test suite only ever ran against the commit, never the tag. The two had already drifted:v1pointed at546ebaa, two commits behindmain, which means the fix-guide slug guard added in #3 was validating code that no user actually runs. A merged fix could stay invisible to every user indefinitely, with CI green the whole time.This adds a
sync-v1job that fast-forwards the tag to eachmaincommit that passes bothfix-guide-slugsandsmoke, so@v1is always the newest tested code.The retag itself is behavior-preserving:
action.ymlis byte-identical betweenv1andmain, andscripts/annotate.pydiffers only in comments (FIX_GUIDE_SLUGSis unchanged), so no current user sees a behavior change when the tag moves.README also documents that
@v1floats within the v1 line, with full-SHA pinning as the alternative for anyone who wants to review every change.