test(e2e): add Files page E2E test coverage - #23
Merged
Conversation
Add 11 comprehensive E2E tests for the Files page covering: - Page load and structure - Scan form with selection features - Browse and scan integration workflow - Scan history and snapshot browsing - Rclone provider support - Provider/root selection - API availability (both /api/scan and /api/tasks) All tests pass on current main (11/11). Pre-existing test failure in test_folder_config_precedence is unrelated. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove dual scan mechanisms and replace with single unified workflow: **Removed:** - Synchronous scan form with selection checkboxes (lines 41-62) - Checkbox column in file browser table - Complex selection rules and state management JavaScript - provScanForm event handler (~70 lines of sync scan logic) **Added:** - "Current Location" display in provider panel showing active folder - Unified "🔍 Scan This Folder" button (disabled until folder selected) - Auto-populate scan context from browser state - All scans now use /api/tasks (background) for consistent UX **Benefits:** - Single scan workflow (no confusion between sync/async) - Better progress tracking (all scans visible in "Scans Summary") - Simpler UI with clearer call-to-action - Removed 100+ lines of complex selection management code All 11 E2E tests pass, validating the consolidated workflow. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The test_files_page_e2e.py module requires BeautifulSoup for HTML parsing and validation. This fixes the CI import error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
patchmemory
force-pushed
the
test/files-page-e2e-coverage
branch
from
January 16, 2026 18:34
e41a097 to
fea18af
Compare
The 'Start Background Scan' form was redundant with the unified '🔍 Scan This Folder' button now in the Files section provider panel. Removed: - Background scan form (lines 176-192) - scan-path input, scan-recursive checkbox, Start Scan button - bg-use-current button handler - scanForm submit event handler The unified scan button in the provider panel is now the only way to initiate scans, providing a cleaner single-workflow UX. Tasks list and recent scans dropdown remain under 'Scans Summary'. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
E2E Playwright tests expect 'files-title' and 'files-root' testids. These were accidentally removed when consolidating the UX. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 11 comprehensive E2E tests for the Files page that were salvaged from the stale
task/task-core-architecture/mvp/selective-scan-cachebranch (127 commits behind main).What This PR Adds
New test file:
tests/test_files_page_e2e.pyTest Coverage (11 tests)
Test Results
All 11 tests pass on current main:
What Happened to the Original Branch?
The branch
task/task-core-architecture/mvp/selective-scan-cachewas 127 commits behind main because:Notes
test_folder_config_precedenceexists on main (unrelated to this PR)🤖 Generated with Claude Code