Skip to content

Chore/ci remove invalid pytest flag #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patchmemory merged 7 commits into from
Dec 19, 2025
Merged

Chore/ci remove invalid pytest flag #11

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
294a605
ci(e2e): remove deprecated Playwright action use and install Chromium…
patchmemory Dec 18, 2025
55e1982
ci(e2e): use npx playwright install-deps and install on ubuntu-latest…
patchmemory Dec 18, 2025
7558255
ci(e2e): remove invalid pytest flag --suppress-no-test-exit-code from…
patchmemory Dec 18, 2025
d54a9de
ci(e2e): install Playwright browsers via npx on CI; remove invalid py…
patchmemory Dec 19, 2025
367a0dd
ci(e2e): ensure TMPDIR exists before installing Playwright; install c…
patchmemory Dec 19, 2025
ce845fe
ci(e2e): fix Playwright install on GitHub Actions; create TMPDIR befo…
patchmemory Dec 19, 2025
9ebac3d
ci(e2e): install Playwright browsers via Python CLI to match Python p…
patchmemory Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,22 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install Python deps
- name: Upgrade pip and install Python deps
run: |
python -m pip install --upgrade pip
pip install -e .[dev]
- name: Install Playwright browsers
if: matrix.tier == 'e2e'
uses: microsoft/playwright-github-action@v1
- name: Prepare repo-local temp directories
run: |
mkdir -p dev/test-runs/{tmp,pytest-tmp,artifacts,downloads,pw-browsers}
- name: Install Playwright browsers (python CLI, repo-local)
if: matrix.tier == 'e2e'
env:
PLAYWRIGHT_BROWSERS_PATH: ${{ github.workspace }}/dev/test-runs/pw-browsers
TMPDIR: ${{ github.workspace }}/dev/test-runs/tmp
TMP: ${{ github.workspace }}/dev/test-runs/tmp
TEMP: ${{ github.workspace }}/dev/test-runs/tmp
run: |
python -m playwright install chromium
- name: Run tests by tier
env:
SCIDK_E2E: ${{ matrix.tier == 'e2e' && '1' || '0' }}
Expand All @@ -42,7 +48,7 @@ jobs:
pytest -m integration -q
;;
e2e)
pytest -m e2e tests/e2e -v --maxfail=1 --suppress-no-test-exit-code
pytest -m e2e tests/e2e -v --maxfail=1
;;
esac
- name: Upload Playwright report (on failure)
Expand Down