Skip to content

doc: use optimistix for IFT in multiphysics demo#656

Open
jpbrodrick89 wants to merge 1 commit into
dion/demo-multiphysicsfrom
jpb/demo-multiphysics
Open

doc: use optimistix for IFT in multiphysics demo#656
jpbrodrick89 wants to merge 1 commit into
dion/demo-multiphysicsfrom
jpb/demo-multiphysics

Conversation

@jpbrodrick89

@jpbrodrick89 jpbrodrick89 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Relevant issue or PR

Description of changes

  • Made a minimal change to step 7 showing that optimistix implements the implicit function already and linking to other pedagogical sources on the matter.
  • Dropped 64-bit enable as Tesseracts are 32 bit, it made no sense to do convergence checks in 64 bit and also led to an optimistix error due to inconsistent dtypes of input and output.

Testing done

  • Ran notebook end-to-end
  • Tried out nonlinear least square but 4 sensors wasn't enough to show a real

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.03%. Comparing base (93f5fcb) to head (906c585).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           dion/demo-multiphysics     #656   +/-   ##
=======================================================
  Coverage                   78.03%   78.03%           
=======================================================
  Files                          39       39           
  Lines                        4685     4685           
  Branches                      770      770           
=======================================================
  Hits                         3656     3656           
  Misses                        720      720           
  Partials                      309      309           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dionhaefner dionhaefner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just make sure the tests are green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants