added theorems#68
Conversation
There was a problem hiding this comment.
Thanks for the contribution! The theorem environments look great and will be a nice addition to the template.
Just a heads up: I renamed the default branch from master to main. Please rebase your branch onto main. I also added contributing guidelines that describe the commit conventions and build requirements.
I have a few suggestions below. The main one is a naming conflict with beamer that needs to be resolved.
| \newtheorem{answ}{\lgansw}[quest] | ||
| \newtheorem{expl}{\lgexpl} | ||
| \newtheorem*{rmk}{\lgrmk} | ||
| \newtheorem*{note}{\lgnote} |
There was a problem hiding this comment.
Blocker: \note is a beamer builtin. This breaks FHVMODE=5 (beamer) with ! LaTeX Error: Command \note already defined.
Suggestion: rename to e.g. notethm or wrap it in a conditional to skip it for beamer.
| \makeatletter | ||
| % define a macro \Autoref to allow multiple references to be passed to \autoref | ||
| \newcommand\Autoref[1]{\@first@ref#1,@} | ||
| \newcommand\AutorefMult[1]{\@first@ref#1,@} |
There was a problem hiding this comment.
Thanks for the explanation. Makes sense since thmtools defines \Autoref. Please update the comment on line 6 to match the new name \AutorefMult.
| % | ||
| \if\paper\FHVmode | ||
| \section{Animation in PDFs} | ||
| \section{Animation in PDFs} |
There was a problem hiding this comment.
Nitpick: indentation change on existing \section/\chapter lines is unrelated to this feature.
|
|
||
|
|
There was a problem hiding this comment.
Nitpick: two blank lines added at end of file, no functional change.
2 participants
While writing my thesis, I have added support for framed mathematical theorems/proofs based on sleek theorems.
It also allows a variety of other framed environments like notes, tips and questions/answers.
Maybe it might be also useful for other users.
The command \Autoref is already used by the necessary package thmtools,
therefore I took the liberty to rename the custom macro \Autoref in sty/Commands.sty to \AutorefMult
(which I think also a more descriptive name).