fuzzy logic on emulation target times - #258
Merged
Merged
Conversation
|
a-quelle-pasqal
marked this pull request as ready for review
September 4, 2026 14:21
murogrande
reviewed
Sep 8, 2026
murogrande
reviewed
Sep 8, 2026
murogrande
left a comment
murogrande
left a comment
Contributor
There was a problem hiding this comment.
small comment regarding a test, apart from this everything looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When observables have evaluation times that are within
1e-12(the current pulser tolerance) of eachother or the multiples ofdtthen the evaluation times of theStatisticsobservable will fall within this tolerance and cause an error. Solve the issue by merging thetarget_timesin the pulser adapter using a fuzzy logic with the above tolerance. Since evaluation times of observables are computed using the same tolerance, this will not cause any observables to be dropped (though they might be reported at a time that is within1e-12of the originally requested time).