Skip to content

fix(editor): guard onShelfMove against null cursorGroupRef (Sentry EDITOR-BC, 53k+ events) #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anton-pascal wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(editor): guard onShelfMove against null cursorGroupRef (Sentry EDITOR-BC, 53k+ events) #342

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/editor/src/components/tools/item/use-placement-coordinator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,13 @@ export function usePlacementCoordinator(config: PlacementCoordinatorConfig): Rea

const onShelfMove = (event: ShelfEvent) => {
has3DPointerDrivenMoveRef.current = true
// Guard against null ref. The mitt event listener can fire after the
// component unmounts (or before the <group ref> attaches), and the
// unguarded `cursorGroupRef.current.rotation.y = ...` write below was
// the source of EDITOR-BC (`Cannot read properties of null (reading
// 'rotation')`) — 53k+ events. Every other surface-move handler in
// this file already has this guard; onShelfMove was missed in #323.
if (!cursorGroupRef.current) return
const ctx = getContext()
if (ctx.state.surface !== 'shelf-surface') {
// Cursor entered via a move event without an enter — try
Expand Down