statement-store: stop a subscription when deduplication can no longer be guaranteed - #3338
Draft
AndreiEres wants to merge 1 commit into
Draft
statement-store: stop a subscription when deduplication can no longer be guaranteed#3338AndreiEres wants to merge 1 commit into
AndreiEres wants to merge 1 commit into
Conversation
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR series, in merge order:
Part 4/5 of the series splitting #3330.
A
statement_unstable_subscribesubscription is stopped, with astopevent, once its deduplication cache is full: remembering one more statement would evict the oldest entry, after which that statement could be reported twice, violating the at-most-once guarantee. With the defaultmaxSeenStatementsof 65536 a subscription therefore dies after roughly that many distinct statements and the client resubscribes.Legacy subscriptions keep evicting silently, the old API having no way to report this.
🤖 Generated with Claude Code