fix: drop [triggers] block from backend Pages config#452
Merged
Conversation
wrangler ≥4.9x validates wrangler.toml as a Pages config (it has pages_build_output_dir) and hard-errors on [triggers]: "Configuration file for Pages projects does not support 'triggers'" — every pages deploy fails before upload. The block was documentation only (Pages Functions never ran the cron); keep the cadence documented in a comment and point at the deletion worker's own wrangler.toml, which is where the cron actually lives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrangler ≥4.9x treats
apps/backend/wrangler.tomlas a Pages config (it haspages_build_output_dir) and rejects the[triggers]block outright — everywrangler pages deployfails validation before upload. Found during the first production launch of the share backend.The block was documentation only (Pages Functions never ran the cron). The cadence stays documented in a comment pointing at
workers/spool-share-deletion/wrangler.toml, where the cron actually lives.Note for a follow-up: the same wrangler versions also require binding
idfields in config-based Pages deploys, sopnpm run deploy:staging/prodno longer works with the id-less checked-in config — this launch used local id-carrying configs (wrangler.{staging,prod}.toml, untracked) swapped in at deploy time. Worth deciding whether to script that swap or gitignore the local configs.