build: upgrade Electron and SQLite native runtime#448
Open
AmagiDDmxh wants to merge 1 commit into
Open
Conversation
AmagiDDmxh
force-pushed
the
feat/electron43-native-upgrade
branch
from
July 16, 2026 04:39
1a81414 to
3c04582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The app was on Electron 34, outside Electron's latest-three-major support window, while the shared native database dependency remained on
better-sqlite311. The two upgrades need to move together because Spool uses the same addon from Electron, Node-based tests, and the CLI.better-sqlite312 drops EOL Node/Electron targets, supports Node 20-26, and contains the V8 compatibility needed by current Electron releases. This PR treats the change as one native-runtime migration rather than an automated dependency bump.What changed
better-sqlite3version from 11.10.0 to 12.11.1 across app, core, and CLI.@electron/rebuildto 4.2.0,@electron/asarto 4.2.0, and electron-builder to 26.15.3.share-backend, which imports Node test APIs, instead of imposing a repository-wide type override.@electron/rebuildresolve its compatiblenode-abi4.33.0 through the lockfile; no transitive override is required for Electron 43 ABI 148.Verification
pnpm installboth passed without changing the lockfile.Size and timing