Add remote_provider = "..." option, replacing scheme-look-ups - #20240
Merged
Conversation
8 tasks
huonw
force-pushed
the
huonw/19902-separate-provider
branch
from
December 29, 2023 07:08
9b71329 to
a9c19a8
Compare
huonw
force-pushed
the
huonw/19902-separate-provider
branch
from
December 30, 2023 05:02
a9c19a8 to
5479720
Compare
huonw
commented
Dec 30, 2023
| // of truth. | ||
| #[derive(Clone, Copy, Debug, strum_macros::EnumString)] | ||
| #[strum(serialize_all = "kebab-case")] | ||
| pub enum RemoteProvider { |
Contributor
Author
There was a problem hiding this comment.
This enum is duplicated in both Rust and Python, but I think that happens elsewhere too (e.g. CacheContentBehavior), so it seems tolerable.
huonw
marked this pull request as ready for review
December 30, 2023 06:51
tgolsson
approved these changes
Jan 15, 2024
tgolsson
left a comment
tgolsson
left a comment
Contributor
There was a problem hiding this comment.
Nice, much cleaner and easy to read now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the over-complicated address URI scheme-based look-up from #19827 for deciding on which provider to use with just a normal option
[GLOBAL].remote_provider. This defaults toreapi, to preserve the current (stable) behaviour.That is, now, one can set:
Or similar.
Another item in #19694
The commits are somewhat usefully broken up for review.