Fix Store benchmarks - #20057
Merged
Merged
Conversation
stuhood
added
the
category:internal
stuhood
enabled auto-merge (squash)
October 18, 2023 21:34
huonw
approved these changes
Oct 19, 2023
huonw
left a comment
huonw
left a comment
Contributor
There was a problem hiding this comment.
Ah oops, thanks.
(For our future reference, in case it matters, this was broken by #19958.)
I believe that cargo test --benches (or something along those lines) allows running benchmarks in "test mode" where they only execute once to provide some sort of assurance that they're functional. I wonder if we could do that too and how big of an impact on CI time it would be.
This was referenced Oct 23, 2023
stuhood
pushed a commit
that referenced
this pull request
Oct 31, 2023
Cargo/criterion supports running benchmarks in "test" mode, where they only execute once and don't actually benchmark, but at least validate that the code seems to run. This fixes #20067 by switching CI to do this. The store benchmark (the only benchmarks at the moment) seems to take ~80s to run in CI. Is it worth it to avoid problems like #20057?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the location of
all_the_henries.txtto allowStorebenchmarks to run.