Skip to content

fix: resolve issues #884, #885, #886, #888#889

Merged
pando85 merged 2 commits into
masterfrom
fix/issues-884-885-886-888
Jul 8, 2026
Merged

fix: resolve issues #884, #885, #886, #888#889
pando85 merged 2 commits into
masterfrom
fix/issues-884-885-886-888

Conversation

@pando85

@pando85 pando85 commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

This PR fixes four issues reported today:

Issue #884: CRD plural typo

  • Fixed kanidmpersonsaccountskanidmpersonaccounts in libs/person/src/crd.rs
  • kubectl get kanidmpersonaccounts now works correctly

Issue #885: Quickstart missing login instructions

  • Added "Step 6: Access Your Kanidm Instance" to quickstart guide
  • Includes admin credential retrieval, person account password setup, and web UI login instructions

Issue #886: initContainers pod not starting

  • Modified libs/operator/src/kanidm/reconcile/statefulset.rs to filter out user init containers named kanidm-generate-replication-config when replication is disabled
  • Added unit test in libs/k8s-util/src/resources.rs to verify merge behavior preserves image field
  • Added e2e test kanidm_init_containers_without_replication to validate the fix

Issue #888: Wrong comment in examples/kanidm.yaml

  • Fixed in the example generator binary (cmd/examples/src/yaml.rs and cmd/examples/src/main.rs) instead of directly in the generated YAML
  • Added write_to_file_with_overrides() function to support post-processing of generated comments
  • Regenerated examples/kanidm.yaml with correct PVC storage comment

Verification

  • make lint passes
  • make test passes
  • All changes follow existing code patterns and conventions

- #884: Fix CRD plural typo (kanidmpersonsaccounts -> kanidmpersonaccounts)
- #885: Add login instructions to quickstart guide
- #886: Filter out replication init containers when replication is disabled
- #886: Add e2e test for initContainers without replication
- #888: Fix PVC comment in example generator (not in generated YAML)
@pando85 pando85 enabled auto-merge (squash) July 8, 2026 18:10
Fixed typo in validating webhook configuration where 'kanidmpersonsaccounts'
was used instead of 'kanidmpersonaccounts'. This prevented the webhook from
being triggered for person account creation, allowing duplicate persons
across namespaces.

Resolves: #889
@forkline-bot

forkline-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Fixed typo in validating webhook configuration where kanidmpersonsaccounts was used instead of kanidmpersonaccounts. This prevented the webhook from being triggered for person account creation, allowing duplicate persons across namespaces.

The service account resource version test that failed is flaky (passed on retry) and unrelated to this fix.

@forkline-bot

forkline-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Fix pushed:

Summary

Fixed the CI failure by correcting a typo in the validating webhook configuration.

Root Cause:
The webhook configuration had kanidmpersonsaccounts (with extra 's') instead of kanidmpersonaccounts, preventing the webhook from being triggered for person account creation. This allowed the person_duplicate_across_namespaces test to fail because duplicates weren't being rejected.

Changes:

  • Fixed resource name typo in charts/kaniop/templates/webhook/validating-webhook-configuration.yaml:46
  • Updated corresponding test in charts/kaniop/tests/validating-webhook-configuration_test.yaml:50

Note: The service_account_resource_version_stable_with_multiple_mails test is flaky (passed on retry) and unrelated to this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant