fix: resolve issues #884, #885, #886, #888#889
Conversation
- #884: Fix CRD plural typo (kanidmpersonsaccounts -> kanidmpersonaccounts) - #885: Add login instructions to quickstart guide - #886: Filter out replication init containers when replication is disabled - #886: Add e2e test for initContainers without replication - #888: Fix PVC comment in example generator (not in generated YAML)
Fixed typo in validating webhook configuration where 'kanidmpersonsaccounts' was used instead of 'kanidmpersonaccounts'. This prevented the webhook from being triggered for person account creation, allowing duplicate persons across namespaces. Resolves: #889
|
Fixed typo in validating webhook configuration where The service account resource version test that failed is flaky (passed on retry) and unrelated to this fix. |
|
✅ Fix pushed: SummaryFixed the CI failure by correcting a typo in the validating webhook configuration. Root Cause: Changes:
Note: The |
Summary
This PR fixes four issues reported today:
Issue #884: CRD plural typo
kanidmpersonsaccounts→kanidmpersonaccountsinlibs/person/src/crd.rskubectl get kanidmpersonaccountsnow works correctlyIssue #885: Quickstart missing login instructions
Issue #886: initContainers pod not starting
libs/operator/src/kanidm/reconcile/statefulset.rsto filter out user init containers namedkanidm-generate-replication-configwhen replication is disabledlibs/k8s-util/src/resources.rsto verify merge behavior preserves image fieldkanidm_init_containers_without_replicationto validate the fixIssue #888: Wrong comment in examples/kanidm.yaml
cmd/examples/src/yaml.rsandcmd/examples/src/main.rs) instead of directly in the generated YAMLwrite_to_file_with_overrides()function to support post-processing of generated commentsexamples/kanidm.yamlwith correct PVC storage commentVerification
make lintpassesmake testpasses