fix: always patch mac_alias, not just on fresh venv install#86
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gpucomm-hq
approved these changes
Jul 7, 2026
Contributor
|
Nuntius: Gemini quota exceeded 😅 Nuntius hit a Gemini quota/rate limit and will pause auto-analysis for this PR. Auto-analysis resumes after: 2026-07-07 21:09:45 UTC You can retry immediately with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI runner reused the
.build-dsstorevenv from the previous (failed) run, so theif [ ! -d "$PYENV_ROOT" ]block was skipped and themac_aliaspatch was never applied.Move the patching logic outside the conditional so it runs every time, regardless of whether the venv was freshly created or reused from a prior run.