feat: improve macOS DMG installer#84
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Nuntius: Gemini quota exceeded 😅 Nuntius hit a Gemini quota/rate limit and will pause auto-analysis for this PR. Auto-analysis resumes after: 2026-07-07 20:58:12 UTC You can retry immediately with |
gpucomm-hq
approved these changes
Jul 7, 2026
3323324 to
05824ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated DMG packaging with generated .DS_Store, branded installer window, and expanded verification.
Changes
--app-iconflag, extractAppIcon.icnsfor both app bundle and DMG volume icongenerate-dsstore.pyinstead of AppleScript (which no longer persists background on macOS 15); stable volume nameAlma(no version) so aliases stay validlogo.svg→AppIcon.appiconsetfor all macOS icon sizesVerification
All 28 verify checks pass. DMG tested end-to-end: app icon, volume icon, background image, window layout, icon positions persist through mount/unmount cycles.