add guided tour to schedule page#100
Conversation
✅ Deploy Preview for rubycon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds social activities for May 9th, 2026, to the schedule in both YAML and Ruby DSL formats, and implements a new social method in the DSL definition. The reviewer identified missing version and changelog updates required by the style guide, as well as missing emojis in the YAML descriptions. A suggestion was also made to add a where parameter to the social method for consistency.
| - clock: "20:00" | ||
| description: "Dinner + Toga Party! @ Bagno 46" | ||
| tag: "Dinner" | ||
| - date: 2026-05-09 |
There was a problem hiding this comment.
According to the repository style guide (rules 50, 51, and 78), every change must be accompanied by a version increment in rubycon.it/_config.yml and an entry in CHANGELOG.md (including the coder's name). These updates are missing from the current pull request.
References
- Update version in _config.yml and CHANGELOG.md for every change. (link)
| tag: "Social" | ||
|
|
||
| - clock: "11:30" | ||
| description: "Walk to the Mouth of the Rubicon, where the river meets the sea" |
There was a problem hiding this comment.
The description in the YAML data is missing the emoji present in the DSL version. Per rule 79 of the repository style guide, proper emojis should be used to maintain visual consistency and the 'Roman' theme.
description: "🌊 Walk to the Mouth of the Rubicon, where the river meets the sea"References
- Use proper emojis in Roman theme. (link)
1 participant
just agendafunziona, mentrejust testrestituisce dei link mancanti tra le pagine ma succede anche su master senza questi cambiamenti