Skip to content

Validate-fedora-ci-fixes#25

Merged
majamassarini merged 6 commits intopackit:mainfrom
majamassarini:validate-fedora-ci-fixes
Apr 14, 2026
Merged

Validate-fedora-ci-fixes#25
majamassarini merged 6 commits intopackit:mainfrom
majamassarini:validate-fedora-ci-fixes

Conversation

@majamassarini
Copy link
Copy Markdown
Member

More fixes for the validation tests.

Check if fork remote exists before trying to update it. When the fork
already exists, fedpkg fork doesn't create the git remote, causing
git remote set-url to fail. Now we check with git remote get-url and
use git remote add if the remote doesn't exist.

This fixes the "No such remote" error during Pagure test execution.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
For tests with "skip build" in the title, the build is skipped so we
cannot retrigger it with "/packit-stg build". Instead, use the test
comment "/packit-stg test" to trigger test runs.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
GitLab webhook delivery can be delayed by over an hour during high
load, causing the opened PR test to fail even though the webhook
eventually arrives and statuses are created.

For GitLab opened PR triggers, if the initial 3-minute check fails:
- Log an error about the webhook delay
- Wait an additional 60 minutes for the delayed webhook
- If statuses eventually appear, log the delay and continue validation
- Only fail if statuses don't appear after the full extended wait

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Uses StrictHostKeyChecking=accept-new to accept the key on first
connection without prompting.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Configure Sentry to use environment labels "validation-stg" and
"validation-prod" instead of generic labels.

The environment is derived from the DEPLOYMENT configuration, so
errors are automatically tagged with the correct environment.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Increase the delay between validation tests from 1 minute to 3 minutes
for both GitHub and GitLab to avoid overloading packit-service instances.

Otherwise all 4 short running workers and 2 long running workers are overwhelmed by tasks.

Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Comment thread Containerfile
# Configure SSH to not prompt for host key verification
RUN mkdir -p /root/.ssh && \
echo "Host pkgs.fedoraproject.org" >> /root/.ssh/config && \
echo " StrictHostKeyChecking accept-new" >> /root/.ssh/config && \
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably pregenerate the KnownHosts, but I don't think it's worth it here.

Comment thread src/validation/helpers.py
from validation.deployment import DEPLOYMENT

# Set environment based on deployment to distinguish in Sentry
environment = f"validation-{DEPLOYMENT.name}"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@majamassarini majamassarini added this pull request to the merge queue Apr 14, 2026
Merged via the queue into packit:main with commit 014ddc8 Apr 14, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Packit pull requests Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants