Skip to content

Capture exceptions raised by tool calls in y_stream sweep - #799

Merged
jpodivin merged 1 commit into
packit:mainfrom
jpodivin:catch_and_release
Sep 4, 2026
Merged

Capture exceptions raised by tool calls in y_stream sweep#799
jpodivin merged 1 commit into
packit:mainfrom
jpodivin:catch_and_release

Conversation

@jpodivin

@jpodivin jpodivin commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>
@opohorel

opohorel commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

From Codex:

• Review verdict: PR #799 is valid as a diagnostic patch, but it will not fix the sweep.

  • P1 root cause: the Y-stream sweep calls load_rhel_config(), but the CronJob manifest (openshift/cronjob-sweep-y-stream.yml:27) and
    Compose service (compose.yaml:459) never mount rhel-config.json. The image does not copy it either. Every Y-stream check therefore ends
    with FileNotFoundError; Capture exceptions raised by tool calls in y_stream sweep #799 merely sends that error to Sentry.
  • Tests miss this because CheckCveTriageEligibilityTool is fully mocked.
  • Minor inherited issue: quote "sentry-sdk>=2.13.0" in Containerfile.sweep:29. Unquoted > is interpreted as shell redirection.

@jpodivin
jpodivin merged commit f97da9b into packit:main Sep 4, 2026
13 checks passed
@jpodivin
jpodivin deleted the catch_and_release branch September 4, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants