refactor: do not store ids count in offsets#410
Merged
Conversation
f1a5a12 to
aa9e94e
Compare
cheb0
approved these changes
May 21, 2026
aa9e94e to
77a537e
Compare
dab7993 to
e0dfb13
Compare
77a537e to
26717ef
Compare
forshev
approved these changes
Jun 5, 2026
7689790 to
353316d
Compare
26717ef to
5cbff00
Compare
eguguchkin
approved these changes
Jun 23, 2026
353316d to
d5a9842
Compare
5cbff00 to
fe8b2e8
Compare
d5a9842 to
ff611f0
Compare
fe8b2e8 to
223f175
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
- Coverage 70.65% 70.63% -0.02%
==========================================
Files 226 226
Lines 17614 17611 -3
==========================================
- Hits 12445 12440 -5
Misses 4245 4245
- Partials 924 926 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
223f175 to
326908f
Compare
Contributor
🔴 Performance DegradationSome benchmarks have degraded compared to the previous run. Show table
|
326908f to
dfa67ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
BlockOffsetsstored the total number of document IDs alongside the block offsets. This meantWriteOffsetsFilehad to read fromInfo, which is a problem for compaction — we don't have completeInfowhile building the index.If you have used LLM/AI assistance please provide model name and full prompt: