Skip to content

refactor: do not store ids count in offsets#410

Merged
dkharms merged 1 commit into
mainfrom
336-call-info-once
Jun 26, 2026
Merged

refactor: do not store ids count in offsets#410
dkharms merged 1 commit into
mainfrom
336-call-info-once

Conversation

@dkharms

@dkharms dkharms commented Apr 27, 2026

Copy link
Copy Markdown
Member

Description

Previously, BlockOffsets stored the total number of document IDs alongside the block offsets. This meant WriteOffsetsFile had to read from Info, which is a problem for compaction — we don't have complete Info while building the index.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@dkharms dkharms force-pushed the 336-blockbuilder branch from a1eae0f to 25539ea Compare May 7, 2026 08:36
@dkharms dkharms force-pushed the 336-call-info-once branch from f1a5a12 to aa9e94e Compare May 7, 2026 10:07
@dkharms dkharms force-pushed the 336-blockbuilder branch from 25539ea to a7a8eb2 Compare May 13, 2026 17:29
@eguguchkin eguguchkin requested review from cheb0 and forshev May 18, 2026 10:55
@dkharms dkharms force-pushed the 336-blockbuilder branch from a7a8eb2 to 547cd6d Compare May 21, 2026 12:08
@dkharms dkharms force-pushed the 336-call-info-once branch from aa9e94e to 77a537e Compare May 21, 2026 12:17
@dkharms dkharms force-pushed the 336-blockbuilder branch 2 times, most recently from dab7993 to e0dfb13 Compare May 25, 2026 09:37
@dkharms dkharms force-pushed the 336-call-info-once branch from 77a537e to 26717ef Compare May 25, 2026 09:46
@eguguchkin eguguchkin added this to the v0.73.0 milestone Jun 8, 2026
@dkharms dkharms force-pushed the 336-blockbuilder branch 2 times, most recently from 7689790 to 353316d Compare June 10, 2026 10:44
@dkharms dkharms force-pushed the 336-call-info-once branch from 26717ef to 5cbff00 Compare June 10, 2026 10:46
@eguguchkin eguguchkin modified the milestones: v0.73.0, v0.74.0 Jun 22, 2026
Comment thread frac/sealed_loader.go
@dkharms dkharms force-pushed the 336-blockbuilder branch from 353316d to d5a9842 Compare June 24, 2026 10:44
@dkharms dkharms force-pushed the 336-call-info-once branch from 5cbff00 to fe8b2e8 Compare June 24, 2026 10:44
@dkharms dkharms force-pushed the 336-blockbuilder branch from d5a9842 to ff611f0 Compare June 25, 2026 16:54
Base automatically changed from 336-blockbuilder to main June 25, 2026 17:37
@dkharms dkharms force-pushed the 336-call-info-once branch from fe8b2e8 to 223f175 Compare June 25, 2026 17:38
@dkharms dkharms enabled auto-merge (squash) June 25, 2026 17:41
@codecov-commenter

codecov-commenter commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.63%. Comparing base (a398a4e) to head (dfa67ba).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
frac/sealed_loader.go 33.33% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   70.65%   70.63%   -0.02%     
==========================================
  Files         226      226              
  Lines       17614    17611       -3     
==========================================
- Hits        12445    12440       -5     
  Misses       4245     4245              
- Partials      924      926       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dkharms dkharms force-pushed the 336-call-info-once branch from 223f175 to 326908f Compare June 25, 2026 17:53
@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
ProcessDocuments-4 3fd6f8 a7f42d
508.00 B/op 11620.00 B/op 22.87 🔴
Sealing_NoSort-4 3fd6f8 a7f42d
24879096.00 B/op 385124584.00 B/op 15.48 🔴
Sealing_WithSort-4 3fd6f8 a7f42d
40310296.00 B/op 400500424.00 B/op 9.94 🔴

@dkharms dkharms disabled auto-merge June 25, 2026 18:02
@dkharms dkharms force-pushed the 336-call-info-once branch from 326908f to dfa67ba Compare June 26, 2026 08:14
@dkharms dkharms merged commit 98c583d into main Jun 26, 2026
8 checks passed
@dkharms dkharms deleted the 336-call-info-once branch June 26, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants